[libcamera-devel] [PATCH v3 1/3] android: camera_device: Introduce Camera3StreamConfig

[Jacopo Mondi]

Hi Hiro,

On Mon, Dec 07, 2020 at 08:42:16AM +0000, Hirokazu Honda wrote:
> Camera3StreamConfig is a new class to store camera3_stream and
> types with associated StreamConfiguration.

All the patches are missing your Signed-off-by: tag :'(

> ---
>  src/android/camera_device.cpp | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index 675af570..09269d95 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -128,6 +128,18 @@ const std::map<int, const Camera3Format> camera3FormatsMap = {
>  	},
>  };
>
> +/*
> + * \struct Camera3StreamConfig
> + * \brief Data to store StreamConfiguration associated with camera3_stream(s).
> + * \var streams List of streams requested by Android HAL client.
> + * \var types List of CameraStream::Type associated with streams.
> + * \var config StreamConfiguration for streams.
> + */
> +struct Camera3StreamConfig {
> +	std::vector<camera3_stream_t*> streams;
> +	std::vector<CameraStream::Type> types;
> +	StreamConfiguration config;
> +};

Looks good!
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
  j

>  } /* namespace */
>
>  LOG_DECLARE_CATEGORY(HAL)
> --
> 2.29.2.576.ga3fc446d84-goog