[libcamera-devel] [PATCH v4 3/3] ipa: raspberrypi: config: Update shutter speeds for imx219/477 and ov5647

[David Plowman]

Hi Naush

Thanks for these changes. I've been using them and it behaves as I
expect - I got 33ms max exposure during preview (because I set fps 30)
and then it goes up to 66ms for capture (when I clear the fps
setting). Perfect!

As I mentioned in my previous email, running at 30fps we see the issue
where the exposure deficit (versus the exposure profile) gets made up
as digital, not analogue, gain - so we'll need to work on the business
of getting the max exposure into the AGC. But that can happen later.

Reviewed-by: David Plowman <david.plowman at raspberrypi.com>
Tested-by: David Plowman <david.plowman at raspberrypi.com>

Best regards
David

On Wed, 9 Dec 2020 at 10:26, Naushir Patuck <naush at raspberrypi.com> wrote:
>
> Set the maximum shutter speed for the normal exposure profile to 66ms.
> Set the maximum shutter speed for the sport exposure profile to 33ms.
> Add a long exposure profile to allow shutter speeds of up to 120ms.
>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> ---
>  src/ipa/raspberrypi/data/imx219.json | 15 +++++++++++++--
>  src/ipa/raspberrypi/data/imx477.json | 15 +++++++++++++--
>  src/ipa/raspberrypi/data/ov5647.json | 15 +++++++++++++--
>  3 files changed, 39 insertions(+), 6 deletions(-)
>
> diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json
> index 212f8b9a..1ec338be 100644
> --- a/src/ipa/raspberrypi/data/imx219.json
> +++ b/src/ipa/raspberrypi/data/imx219.json
> @@ -133,7 +133,7 @@
>              {
>                  "shutter":
>                  [
> -                    100, 10000, 30000, 30000, 30000
> +                    100, 10000, 30000, 60000, 66666
>                  ],
>                  "gain":
>                  [
> @@ -144,7 +144,18 @@
>              {
>                  "shutter":
>                  [
> -                    100, 5000, 10000, 20000, 30000
> +                    100, 5000, 10000, 20000, 33333
> +                ],
> +                "gain":
> +                [
> +                    1.0, 2.0, 4.0, 6.0, 6.0
> +                ]
> +            },
> +            "long":
> +            {
> +                "shutter":
> +                [
> +                    100, 10000, 30000, 60000, 120000
>                  ],
>                  "gain":
>                  [
> diff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json
> index 12fe2f41..9bee3f16 100644
> --- a/src/ipa/raspberrypi/data/imx477.json
> +++ b/src/ipa/raspberrypi/data/imx477.json
> @@ -133,7 +133,7 @@
>              {
>                  "shutter":
>                  [
> -                    100, 10000, 30000, 60000, 120000
> +                    100, 10000, 30000, 60000, 66666
>                  ],
>                  "gain":
>                  [
> @@ -144,7 +144,18 @@
>              {
>                  "shutter":
>                  [
> -                    100, 5000, 10000, 20000, 120000
> +                    100, 5000, 10000, 20000, 33333
> +                ],
> +                "gain":
> +                [
> +                    1.0, 2.0, 4.0, 6.0, 6.0
> +                ]
> +            },
> +            "long":
> +            {
> +                "shutter":
> +                [
> +                    100, 10000, 30000, 60000, 120000
>                  ],
>                  "gain":
>                  [
> diff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json
> index 3d8a7c8f..1a354f7c 100644
> --- a/src/ipa/raspberrypi/data/ov5647.json
> +++ b/src/ipa/raspberrypi/data/ov5647.json
> @@ -133,7 +133,7 @@
>              {
>                  "shutter":
>                  [
> -                    100, 10000, 30000, 30000, 30000
> +                    100, 10000, 30000, 60000, 66666
>                  ],
>                  "gain":
>                  [
> @@ -144,7 +144,18 @@
>              {
>                  "shutter":
>                  [
> -                    100, 5000, 10000, 20000, 30000
> +                    100, 5000, 10000, 20000, 33333
> +                ],
> +                "gain":
> +                [
> +                    1.0, 2.0, 4.0, 6.0, 6.0
> +                ]
> +            },
> +            "long":
> +            {
> +                "shutter":
> +                [
> +                    100, 10000, 30000, 60000, 120000
>                  ],
>                  "gain":
>                  [
> --
> 2.25.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel