[libcamera-devel] [PATCH 0/2] libcamera: Introduce sensor database

[Jacopo Mondi]

Hi Niklas, Laurent,

On Thu, Dec 10, 2020 at 06:17:42PM +0200, Laurent Pinchart wrote:
> Hello,
>
> On Thu, Dec 10, 2020 at 05:09:00PM +0100, Niklas Söderlund wrote:
> > On 2020-12-08 10:00:40 +0100, Jacopo Mondi wrote:
> > > Introduce a database of camera sensor properties to record the camera
> > > sensor characteristics which are not retrievable at run-time.
> >
> > I have looked at the series and on their own I think the patches are
> > good. I'm a little concerned if this is the API we want to use for this.
> > Would it not make more sens for users (like the HAL) to read this
> > information as static metadata exposed by the camera? Maybe there is
> > some use-case I do not understand.
>
> I was going to mention the same. I think the database should be internal
> to the CameraSensor class, which would create corresponding properties.
> The HAL would then translate those properties to HAL metadata.
>

yes, we had this discussion last week and concluded that the config
file will be parsed by the camera sensor and properties exposed by it
using, if required, draft ones.

> > > The per-sensor entries can easily be generated from a yaml schema.
> > >
> > > Jacopo Mondi (2):
> > >   libcamera: Introduce camera sensor database
> > >   android: camera_device: Get sensor properties from DB
> > >
> > >  include/libcamera/camera_sensor_database.h |  41 +++++++
> > >  include/libcamera/meson.build              |   1 +
> > >  src/android/camera_device.cpp              |  27 ++++-
> > >  src/libcamera/camera_sensor_database.cpp   | 119 +++++++++++++++++++++
> > >  src/libcamera/meson.build                  |   1 +
> > >  5 files changed, 184 insertions(+), 5 deletions(-)
> > >  create mode 100644 include/libcamera/camera_sensor_database.h
> > >  create mode 100644 src/libcamera/camera_sensor_database.cpp
>
> --
> Regards,
>
> Laurent Pinchart