[libcamera-devel] [PATCH v6 1/3] android: camera_device: Introduce Camera3StreamConfig

[Jacopo Mondi]

Hello,

On Fri, Dec 11, 2020 at 06:03:13AM +0000, Hirokazu Honda wrote:
> Camera3StreamConfig is a new class to store camera3_stream and
> types with associated StreamConfiguration.
>
> Signed-off-by: Hirokazu Honda <hiroh at chromium.org>
> Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Reviewed-by: Umang Jain <email at uajain.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/android/camera_device.cpp | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index 872c7b18..58ff329c 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -128,6 +128,22 @@ const std::map<int, const Camera3Format> camera3FormatsMap = {
>  	},
>  };
>
> +/*
> + * \struct Camera3StreamConfig
> + * \brief Data to store StreamConfiguration associated with camera3_stream(s).
> + * \var streams List of the pairs of a stream requested by Android HAL client
> + * and associated CameraStream::Type associated with the stream.

One of the two 'associated' should be removed when applying.

> + * \var config StreamConfiguration for streams.
> + */
> +struct Camera3StreamConfig {
> +	struct Camera3Stream {
> +		camera3_stream_t* stream;
> +		CameraStream::Type type;
> +	};
> +
> +	std::vector<Camera3Stream> streams;
> +	StreamConfiguration config;
> +};
>  } /* namespace */
>
>  LOG_DECLARE_CATEGORY(HAL)
> --
> 2.29.2.576.ga3fc446d84-goog