[libcamera-devel] [PATCH] android: camera_device: Replace auto with explicit type

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sat Dec 12 04:42:11 CET 2020


The auto keyword facilitates writing code. It avoids typing out very
long types, which can make the code more readable, but it can also have
a negative impact on readability as it requires the reader (including
reviewers) to look up the type of the variable.

Replace one occurrence of auto with the explicit type where doing so
doesn't require a long type name.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/android/camera_device.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index 38689bdc40b1..79fd02eccdcd 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -199,7 +199,7 @@ void sortCamera3StreamConfigs(std::vector<Camera3StreamConfig> &unsortedConfigs,
 	const auto nv12It = formatToConfigs.find(formats::NV12);
 	if (nv12It != formatToConfigs.end()) {
 		auto &nv12Configs = nv12It->second;
-		const auto &nv12Largest = nv12Configs.back();
+		const Camera3StreamConfig *nv12Largest = nv12Configs.back();
 
 		/*
 		 * If JPEG will be created from NV12 and the size is larger than
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list