[libcamera-devel] [PATCH v10 3/3] ipa: raspberrypi: config: Update shutter speeds for imx219/477 and ov5647

[Laurent Pinchart]

Hi Naush,

Thank you for the patch.

On Fri, Dec 18, 2020 at 10:06:27AM +0000, Naushir Patuck wrote:
> Set the maximum shutter speed for the normal exposure profile to 66ms.
> Set the maximum shutter speed for the sport exposure profile to 33ms.

It would be nice if we could add a sentence to explain why. The content
of the patch otherwise looks good.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> Add a long exposure profile to allow shutter speeds of up to 120ms.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> Reviewed-by: David Plowman <david.plowman at raspberrypi.com>
> Tested-by: David Plowman <david.plowman at raspberrypi.com>
> ---
>  src/ipa/raspberrypi/data/imx219.json | 15 +++++++++++++--
>  src/ipa/raspberrypi/data/imx477.json | 15 +++++++++++++--
>  src/ipa/raspberrypi/data/ov5647.json | 15 +++++++++++++--
>  3 files changed, 39 insertions(+), 6 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json
> index 212f8b9a..1ec338be 100644
> --- a/src/ipa/raspberrypi/data/imx219.json
> +++ b/src/ipa/raspberrypi/data/imx219.json
> @@ -133,7 +133,7 @@
>              {
>                  "shutter":
>                  [
> -                    100, 10000, 30000, 30000, 30000
> +                    100, 10000, 30000, 60000, 66666
>                  ],
>                  "gain":
>                  [
> @@ -144,7 +144,18 @@
>              {
>                  "shutter":
>                  [
> -                    100, 5000, 10000, 20000, 30000
> +                    100, 5000, 10000, 20000, 33333
> +                ],
> +                "gain":
> +                [
> +                    1.0, 2.0, 4.0, 6.0, 6.0
> +                ]
> +            },
> +            "long":
> +            {
> +                "shutter":
> +                [
> +                    100, 10000, 30000, 60000, 120000
>                  ],
>                  "gain":
>                  [
> diff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json
> index 12fe2f41..9bee3f16 100644
> --- a/src/ipa/raspberrypi/data/imx477.json
> +++ b/src/ipa/raspberrypi/data/imx477.json
> @@ -133,7 +133,7 @@
>              {
>                  "shutter":
>                  [
> -                    100, 10000, 30000, 60000, 120000
> +                    100, 10000, 30000, 60000, 66666
>                  ],
>                  "gain":
>                  [
> @@ -144,7 +144,18 @@
>              {
>                  "shutter":
>                  [
> -                    100, 5000, 10000, 20000, 120000
> +                    100, 5000, 10000, 20000, 33333
> +                ],
> +                "gain":
> +                [
> +                    1.0, 2.0, 4.0, 6.0, 6.0
> +                ]
> +            },
> +            "long":
> +            {
> +                "shutter":
> +                [
> +                    100, 10000, 30000, 60000, 120000
>                  ],
>                  "gain":
>                  [
> diff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json
> index 3d8a7c8f..1a354f7c 100644
> --- a/src/ipa/raspberrypi/data/ov5647.json
> +++ b/src/ipa/raspberrypi/data/ov5647.json
> @@ -133,7 +133,7 @@
>              {
>                  "shutter":
>                  [
> -                    100, 10000, 30000, 30000, 30000
> +                    100, 10000, 30000, 60000, 66666
>                  ],
>                  "gain":
>                  [
> @@ -144,7 +144,18 @@
>              {
>                  "shutter":
>                  [
> -                    100, 5000, 10000, 20000, 30000
> +                    100, 5000, 10000, 20000, 33333
> +                ],
> +                "gain":
> +                [
> +                    1.0, 2.0, 4.0, 6.0, 6.0
> +                ]
> +            },
> +            "long":
> +            {
> +                "shutter":
> +                [
> +                    100, 10000, 30000, 60000, 120000
>                  ],
>                  "gain":
>                  [

-- 
Regards,

Laurent Pinchart