[libcamera-devel] [PATCH v2 1/9] libcamera: properties: SensorPhysicalSize draft property

[Jacopo Mondi]

Hi Laurent,

On Sun, Dec 20, 2020 at 08:02:29AM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Fri, Dec 18, 2020 at 05:47:46PM +0100, Jacopo Mondi wrote:
> > Define the 'SensorPhysicalSize' draft property. The property is
> > currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.
> >
> > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> > ---
> >  src/libcamera/property_ids.yaml | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> > index 64e88f0361d6..f8e32c1bd8cf 100644
> > --- a/src/libcamera/property_ids.yaml
> > +++ b/src/libcamera/property_ids.yaml
> > @@ -678,4 +678,15 @@ controls:
> >          \todo Turn this property into a "maximum control value" for the
> >          ScalerCrop control once "dynamic" controls have been implemented.
> >
> > +  # ----------------------------------------------------------------------------
> > +  # Draft properties section
> > +
> > +  - SensorPhysicalSize:
> > +      type: float
> > +      size: [2]
> > +      draft: true
> > +      description: |
> > +        The physical dimensions of the full pixel array in millimeters.
> > +        Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.
>
> We already have UnitCellSize and PixelArraySize, can't they be used to
> compute this property ?

We could.

I would like to have these cros-verified with the current values
reported by the chromeos HALs. I still haven't been able to have a
nice list of all properties they register.

>
> > +
> >  ...
>
> --
> Regards,
>
> Laurent Pinchart