[libcamera-devel] [PATCH v2 1/5] libcamera: properties: ColorFilterArrangement draft property

[Jacopo Mondi]

Hi David,

On Tue, Dec 29, 2020 at 09:25:14AM +0000, David Plowman wrote:
> Hi Jacopo
>
> Thanks for this patch! Just one little question - I suppose Android
> (and libcamera) have some other way of signalling a monochrome
> sensor... I think I might have expected to find a
> "monochrome/non-Bayer" option in the list?

Please bare in mind this is a draft property, whose main purpose is
to temporary close the gap with Android and its definition come
straight from there.

This property only makes sensor for RAW sensors, although there's a
more generic 'RGB' value that sounds like a catch-all for non-Bayer
sensors.

Simply put: non-RAW sensor won't register this property at all.
When we'll un-draft the property we can discuss if that makes sense
at all as a choice, or we might want to have a more generic
definition.

Do you perhaps have any usage for such a more generic property in mind ?

>
> Best regards
> David
>
> On Tue, 29 Dec 2020 at 04:56, <paul.elder at ideasonboard.com> wrote:
> >
> > Hi Jacopo,
> >
> > On Mon, Dec 28, 2020 at 05:39:59PM +0100, Jacopo Mondi wrote:
> > > Define the 'ColorFilterArrangement' draft property. The property is
> > > currently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.
> > >
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> >
> > Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
> >
> > > ---
> > >  src/libcamera/property_ids.yaml | 29 +++++++++++++++++++++++++++++
> > >  1 file changed, 29 insertions(+)
> > >
> > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> > > index 64e88f0361d6..104e9aaf4fa3 100644
> > > --- a/src/libcamera/property_ids.yaml
> > > +++ b/src/libcamera/property_ids.yaml
> > > @@ -678,4 +678,33 @@ controls:
> > >          \todo Turn this property into a "maximum control value" for the
> > >          ScalerCrop control once "dynamic" controls have been implemented.
> > >
> > > +  # ----------------------------------------------------------------------------
> > > +  # Draft properties section
> > > +
> > > +  - ColorFilterArrangement:
> > > +      type: int32_t
> > > +      draft: true
> > > +      description: |
> > > +        The arrangement of color filters on sensor; represents the colors in the
> > > +        top-left 2x2 section of the sensor, in reading order. Currently
> > > +        identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.
> > > +      enum:
> > > +        - name: RGGB
> > > +          value: 0
> > > +          description: RGGB Bayer pattern
> > > +        - name: GRBG
> > > +          value: 1
> > > +          description: GRBG Bayer pattern
> > > +        - name: GBRG
> > > +          value: 2
> > > +          description: GBRG Bayer pattern
> > > +        - name: BGGR
> > > +          value: 3
> > > +          description: BGGR Bayer pattern
> > > +        - name: RGB
> > > +          value: 4
> > > +          description: |
> > > +            Sensor is not Bayer; output has 3 16-bit values for each pixel,
> > > +            instead of just 1 16-bit value per pixel.
> > > +
> > >  ...
> > > --
> > > 2.29.2
> > >
> > > _______________________________________________
> > > libcamera-devel mailing list
> > > libcamera-devel at lists.libcamera.org
> > > https://lists.libcamera.org/listinfo/libcamera-devel
> > _______________________________________________
> > libcamera-devel mailing list
> > libcamera-devel at lists.libcamera.org
> > https://lists.libcamera.org/listinfo/libcamera-devel