[libcamera-devel] [PATCH 4/6] qcam: assets: Provide initial icon set

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Thu, Feb 06, 2020 at 03:05:02PM +0000, Kieran Bingham wrote:
> Provide simple clean icons from https://feathericons.com/
> (https://github.com/feathericons/feather)
> 
> These are provided under the MIT license.

Could you add a copy of the license to licenses/ ?

> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  src/qcam/assets/feathericons/README.md        |   5 +
>  src/qcam/assets/feathericons/feathericons.qrc | 288 ++++++++++++++++++
>  src/qcam/assets/feathericons/*.svg            |     +
> 
> diff --git a/src/qcam/assets/feathericons/README.md b/src/qcam/assets/feathericons/README.md
> new file mode 100644
> index 000000000000..ce7664f6bf16
> --- /dev/null
> +++ b/src/qcam/assets/feathericons/README.md
> @@ -0,0 +1,5 @@
> +Icons from https://feathericons.com/
> +License: MIT
> +
> +Generate the QRC file with:
> + rcc --project
> diff --git a/src/qcam/assets/feathericons/activity.svg b/src/qcam/assets/feathericons/activity.svg
> new file mode 100644
> index 000000000000..669a57a772fa
> --- /dev/null
> +++ b/src/qcam/assets/feathericons/activity.svg
> @@ -0,0 +1 @@

Should we add an SPDX tag here ?

<!-- SPDX-License-Identifier: MIT -->

> +<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="feather feather-activity"><polyline points="22 12 18 12 15 21 9 3 6 12 2 12"></polyline></svg>
> \ No newline at end of file
> 
> < Remaing icons chopped >

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

-- 
Regards,

Laurent Pinchart