[libcamera-devel] [PATCH] QCam: Swich default stream role to viewfinder.

[Niklas Söderlund]

Hi Naushir,

Thanks for your patch.

On 2020-01-31 09:52:45 +0000, naush at raspberrypi.com wrote:
> From: Naushir Patuck <naush at raspberrypi.com>
> 
> QCam currently only displays a standard viewfinder.  As such set the
> StreamRole parameter to Viewfinder so that the pipeline handlers can
> setup the appropriate resolutions and formats.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Small nit for the patch subject,

- Please use qcam: instead of QCam:
- s/Swich/Switch/
- Drop the period (.) at the end of the subject line

With these small things fixed,

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  src/qcam/main_window.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp
> index df51fa8..70a3e61 100644
> --- a/src/qcam/main_window.cpp
> +++ b/src/qcam/main_window.cpp
> @@ -125,7 +125,7 @@ int MainWindow::startCapture()
>  {
>  	int ret;
>  
> -	config_ = camera_->generateConfiguration({ StreamRole::VideoRecording });
> +	config_ = camera_->generateConfiguration({ StreamRole::Viewfinder });
>  
>  	StreamConfiguration &cfg = config_->at(0);
>  	if (options_.isSet(OptSize)) {
> -- 
> 2.17.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund