[libcamera-devel] [PATCH v1 06/23] gst: libcamerasrc: Allocate and add static pad

[Laurent Pinchart]

Hi Nicolas,

Thank you for the patch.

On Tue, Jan 28, 2020 at 10:31:53PM -0500, Nicolas Dufresne wrote:
> From: Nicolas Dufresne <nicolas.dufresne at collabora.com>

A commit message could be nice. Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> Signed-off-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>
> ---
>  src/gstreamer/gstlibcamerasrc.cpp | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp
> index a8bcede..50bba39 100644
> --- a/src/gstreamer/gstlibcamerasrc.cpp
> +++ b/src/gstreamer/gstlibcamerasrc.cpp
> @@ -11,6 +11,7 @@
>  
>  struct _GstLibcameraSrc {
>  	GstElement parent;
> +	GstPad *srcpad;
>  };
>  
>  G_DEFINE_TYPE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT);
> @@ -30,6 +31,10 @@ GstStaticPadTemplate request_src_template = {
>  static void
>  gst_libcamera_src_init(GstLibcameraSrc *self)
>  {
> +	GstPadTemplate *templ = gst_element_get_pad_template(GST_ELEMENT(self), "src");
> +
> +	self->srcpad = gst_pad_new_from_template(templ, "src");
> +	gst_element_add_pad(GST_ELEMENT(self), self->srcpad);
>  }
>  
>  static void

-- 
Regards,

Laurent Pinchart