[libcamera-devel] [PATCH v1 23/23] gst: libcamerasrc: Add a TODO comment

[Laurent Pinchart]

Hi Nicolas,

Thank you for the patch.

On Tue, Jan 28, 2020 at 10:32:10PM -0500, Nicolas Dufresne wrote:
> From: Nicolas Dufresne <nicolas.dufresne at collabora.com>
> 
> This is to guide upcoming contributors toward what is left to do to get
> toward a production element.
> 
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>
> ---
>  src/gstreamer/gstlibcamerasrc.cpp | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp
> index 947a8bf..878ae2f 100644
> --- a/src/gstreamer/gstlibcamerasrc.cpp
> +++ b/src/gstreamer/gstlibcamerasrc.cpp
> @@ -6,6 +6,26 @@
>   * gstlibcamerasrc.cpp - GStreamer Capture Element
>   */
>  
> +/* TODO

s/TODO/\\todo/

> + *  - Implement GstElement::send_event
> + *    + Allowing application to send EOS
> + *    + Allowing application to use FLUSH/FLUSH_STOP
> + *    + Prevent the main thread from accessing streaming thread
> + *  - Implement renegotiation (even if slow)
> + *  - Implement GstElement::request-new-pad (multi stream)
> + *    + Evaluate if a single streaming thread is fine
> + *  - Add application driven request (snapshot)
> + *  - Add framerate control
> + *
> + *  Requires new libcamera API:
> + *  - Add framerate negotiation support
> + *  - Add colorimetry support
> + *  - Add timestamp support
> + *  - Use unique names to select the camera
> + *  - Add GstVideoMeta support (strides and offsets)
> + *  - Add buffer importation support

Even if I don't understand most of the items, it's a nice list :-) I'm
sure we'll get back to you to discuss individual items, but I would like
to already ask about the last one. What is missing for buffer import ?

> + */
> +
>  #include "gstlibcamerasrc.h"
>  #include "gstlibcamerapad.h"
>  #include "gstlibcameraallocator.h"

-- 
Regards,

Laurent Pinchart