[libcamera-devel] [PATCH 0/3] Patchset for libcamera controls

[Naushir Patuck]

Hi,

I would like to discuss the following patch set.  In it are the following
changes:

1) Add double and std::string ControlValue types.
2) Update units and types of existing controls.
3) Add new camera controls.

There are two main points of discussion for (1).  Firstly, I have not added
any support for serialisation of these ControlValue types.  I understand that
the serialisation code is being revamped, so will wait for that to be completed
before addressing this.  Secondly, from eariler discussions, std::string
ControlValue type may not be the most sutiable for AE/AWB modes.  Instead we
may want to use fixed enum values which makes things a little bit more
restrictive.

Thoughts?

Regards,
Naush


Naushir Patuck (3):
  libcamera: controls: Add std::string and double ControlValue type.
  libcamera: controls: Specify manual gain units and change exposure
    units
  libcamera: controls: Add AE/AWB mode, manual and EV controls.

 include/libcamera/controls.h    |  6 +++
 src/libcamera/control_ids.yaml  | 46 +++++++++++++++++++--
 src/libcamera/controls.cpp      | 72 ++++++++++++++++++++++++++++++++-
 test/controls/control_value.cpp | 26 ++++++++++++
 4 files changed, 146 insertions(+), 4 deletions(-)

-- 
2.17.1