[libcamera-devel] [PATCH v2 21/27] gst: pad: Add method to store retrieve pending buffers

Nicolas Dufresne nicolas.dufresne at collabora.com
Thu Feb 27 21:04:01 CET 2020


These will be useful for streaming. The requestComplete callback will
store the buffers on each pads so that the _run() can pick them up
and push them through the pads from a streaming thread.

Signed-off-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/gstreamer/gstlibcamerapad.cpp | 27 +++++++++++++++++++++++++++
 src/gstreamer/gstlibcamerapad.h   |  4 ++++
 2 files changed, 31 insertions(+)

diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp
index 4f96546..8662c92 100644
--- a/src/gstreamer/gstlibcamerapad.cpp
+++ b/src/gstreamer/gstlibcamerapad.cpp
@@ -17,6 +17,7 @@ struct _GstLibcameraPad {
 	GstPad parent;
 	StreamRole role;
 	GstLibcameraPool *pool;
+	GQueue pending_buffers;
 };
 
 enum {
@@ -136,3 +137,29 @@ gst_libcamera_pad_get_stream(GstPad *pad)
 
 	return nullptr;
 }
+
+void
+gst_libcamera_pad_queue_buffer(GstPad *pad, GstBuffer *buffer)
+{
+	auto *self = GST_LIBCAMERA_PAD(pad);
+	GLibLocker lock(GST_OBJECT(self));
+
+	g_queue_push_head(&self->pending_buffers, buffer);
+}
+
+GstFlowReturn
+gst_libcamera_pad_push_pending(GstPad *pad)
+{
+	auto *self = GST_LIBCAMERA_PAD(pad);
+	GstBuffer *buffer;
+
+	{
+		GLibLocker lock(GST_OBJECT(self));
+		buffer = GST_BUFFER(g_queue_pop_tail(&self->pending_buffers));
+	}
+
+	if (!buffer)
+		return GST_FLOW_CUSTOM_SUCCESS;
+
+	return gst_pad_push(pad, buffer);
+}
diff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h
index 81d0d58..d928570 100644
--- a/src/gstreamer/gstlibcamerapad.h
+++ b/src/gstreamer/gstlibcamerapad.h
@@ -26,4 +26,8 @@ void gst_libcamera_pad_set_pool(GstPad *pad, GstLibcameraPool *pool);
 
 libcamera::Stream *gst_libcamera_pad_get_stream(GstPad *pad);
 
+void gst_libcamera_pad_queue_buffer(GstPad *pad, GstBuffer *buffer);
+
+GstFlowReturn gst_libcamera_pad_push_pending(GstPad *pad);
+
 #endif /* __GST_LIBCAMERA_PAD_H__ */
-- 
2.24.1



More information about the libcamera-devel mailing list