[libcamera-devel] [PATCH v2 27/27] gst: Reduce GStreamer requirement to 1.14

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sat Feb 29 16:12:43 CET 2020


Hi Nicolas,

Thank you for the patch.

On Thu, Feb 27, 2020 at 03:04:07PM -0500, Nicolas Dufresne wrote:
> This has been tested to build and run on 1.14, except for the device monitor.
> Mostly, all device monitors that are non-monitoring have been broken for a long
> time.

Does that mean we'll need v1.16 when we'll implement hotplug support, or
that it will work fine on v1.14 ?

> Signed-off-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

You may even want to squash this in patch 01/27.

> ---
>  src/gstreamer/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build
> index 90773af..269b8b6 100644
> --- a/src/gstreamer/meson.build
> +++ b/src/gstreamer/meson.build
> @@ -13,7 +13,7 @@ libcamera_gst_c_args = [
>      '-DPACKAGE="@0@"'.format(meson.project_name()),
>  ]
>  
> -gst_req = '>=1.16.1'
> +gst_req = '>=1.14.0'
>  gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_req,
>                            required : get_option('gstreamer'))
>  gstallocator_dep = dependency('gstreamer-allocators-1.0', version : gst_req,

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list