[libcamera-devel] [PATCH 2/2] libcamera: pipeline: rkisp1: don't enable immutable link

[Laurent Pinchart]

Hi Helen,

Thank you for the patch.

On Thu, Feb 27, 2020 at 12:00:01AM -0300, Helen Koike wrote:
> Link between resizer and capture is immutable and doesn't need to be
> enabled.
> 
> Signed-off-by: Helen Koike <helen.koike at collabora.com>

Just with s/don't/Don't/ in the subject line,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 7f7e1ad..0589d38 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -915,14 +915,6 @@ int PipelineHandlerRkISP1::initLinks()
>  	if (ret < 0)
>  		return ret;
>  
> -	link = media_->link("rkisp1_resizer_mainpath", 1, "rkisp1_mainpath", 0);
> -	if (!link)
> -		return -ENODEV;
> -
> -	ret = link->setEnabled(true);
> -	if (ret < 0)
> -		return ret;
> -
>  	return 0;
>  }
>  

-- 
Regards,

Laurent Pinchart