[libcamera-devel] [PATCH 1/2] utils: rkisp1: don't enable immutable link

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sat Feb 29 16:23:15 CET 2020


Hi Helen,

Thank you for the patch.

On Thu, Feb 27, 2020 at 12:00:00AM -0300, Helen Koike wrote:
> Link between resizer and capture is immutable and doesn't need to be
> enabled.
> 
> Signed-off-by: Helen Koike <helen.koike at collabora.com>

Just with s/don't/Don't/ in the subject line,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  utils/rkisp1/rkisp1-capture.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh
> index 4b789b6..4d09f5d 100755
> --- a/utils/rkisp1/rkisp1-capture.sh
> +++ b/utils/rkisp1/rkisp1-capture.sh
> @@ -70,7 +70,6 @@ configure_pipeline() {
>  
>  	$mediactl -l "'$sensor':0 -> 'rkisp1_isp':0 [1]"
>  	$mediactl -l "'rkisp1_isp':2 -> 'rkisp1_resizer_mainpath':0 [1]"
> -	$mediactl -l "'rkisp1_resizer_mainpath':1 -> 'rkisp1_mainpath':0 [1]"
>  
>  	$mediactl -V "\"$sensor\":0 [$format]"
>  	$mediactl -V "'rkisp1_isp':0 [$format crop:(0,0)/$sensor_size]"

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list