[libcamera-devel] [PATCH v2 3/3] v4l2: camera_proxy: Align trace message style

[Kieran Bingham]

Hi Jacopo,

On 08/01/2020 10:17, Jacopo Mondi wrote:
> Most of the ioctl handlers in the V4L2CameraProxy class have an empty
> line between the tracing printouts and the immediately following buffer
> type validation. Align the two ones where such an empy line is missing

s/the two ones/the two occasions/
s/empy/empty/

> with the others.
> 
> Cosmetic change only.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/v4l2/v4l2_camera_proxy.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
> index f3a49fea2a5a..89dd7166ca52 100644
> --- a/src/v4l2/v4l2_camera_proxy.cpp
> +++ b/src/v4l2/v4l2_camera_proxy.cpp
> @@ -292,6 +292,7 @@ int V4L2CameraProxy::vidioc_s_fmt(struct v4l2_format *arg)
>  int V4L2CameraProxy::vidioc_try_fmt(struct v4l2_format *arg)
>  {
>  	LOG(V4L2Compat, Debug) << "Servicing vidioc_try_fmt";
> +
>  	if (!validateBufferType(arg->type))
>  		return -EINVAL;
>  
> @@ -321,6 +322,7 @@ int V4L2CameraProxy::vidioc_reqbufs(struct v4l2_requestbuffers *arg)
>  	int ret;
>  
>  	LOG(V4L2Compat, Debug) << "Servicing vidioc_reqbufs";
> +
>  	if (!validateBufferType(arg->type) ||
>  	    !validateMemoryType(arg->memory))
>  		return -EINVAL;
> 

-- 
Regards
--
Kieran