[libcamera-devel] [PATCH] libcamera: gen-controls.py: Don't hardcode path to python interpreter

[Kieran Bingham]

Hi Laurent,

On 14/01/2020 11:44, Laurent Pinchart wrote:
> The gen-controls.py script hardcodes the path to the python interpreter
> to /usr/bin/python3 in the first line of the script. This hardcodes
> usage of the host python3, even when building in cross-compilation
> environments that may ship their own version of python. Fix it by
> setting the interpreter to '/usr/bin/env python3'.
> 
> Reported-by: Madhavan Krishnan <madhavan.krishnan at linaro.org>
> Suggested-by: Nicolas Dufresne <nicolas at ndufresne.ca>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Aha - this explains some issues I'd seen in fact.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/libcamera/gen-controls.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/gen-controls.py b/src/libcamera/gen-controls.py
> index 940386cc68c8..2e5ac5c81cca 100755
> --- a/src/libcamera/gen-controls.py
> +++ b/src/libcamera/gen-controls.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/python3
> +#!/usr/bin/env python3
>  # SPDX-License-Identifier: GPL-2.0-or-later
>  # Copyright (C) 2019, Google Inc.
>  #
> 

-- 
Regards
--
Kieran