[libcamera-devel] [PATCH] meson: Bump required version to 0.47

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Jan 15 01:27:02 CET 2020


Hi Nicolas,

Thank you for the patch.

On Tue, Jan 14, 2020 at 01:46:41PM -0500, Nicolas Dufresne wrote:
> This is needed to use option type 'feature'. This is a tri-state
> (auto/enabled/disabled) which comes with utility to enable them all, or
> disabled them all to avoid any dynamic selection happening. It can also
> be used as value to any "required" field.
> 
> This will be used in GStreamer support. If you don't have a recent enough
> meson in your distribution, you can always install or upgrate your version

s/upgrate/upgrade/

> using pip3.
> 
>   pip3 install --user meson
>   pip3 install --user --upgrade meson
> 
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>
> ---
>  meson.build | 2 +-

How about also updating the README.md ?

diff --git a/README.rst b/README.rst
index 48e428cc816e..585c706d9e87 100644
--- a/README.rst
+++ b/README.rst
@@ -45,7 +45,13 @@ A C++ toolchain: [required]
 	Either {g++, clang}

 for libcamera: [required]
-	meson ninja-build python3-yaml
+	meson (>= 0.47) ninja-build python3-yaml
+
+	If your distribution doesn't provide a recent enough version meson, you
+	can install or upgrade it using pip3.
+
+	pip3 install --user meson
+	pip3 install --user --upgrade meson

 for device hotplug enumeration: [optional]
 	pkg-config libudev-dev

If you're fine with all this there's no need to resubmit and I'll update
the patch when applying.

>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 6344885..eec1dcf 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1,5 +1,5 @@
>  project('libcamera', 'c', 'cpp',
> -    meson_version : '>= 0.40',
> +    meson_version : '>= 0.47',
>      version : '0.0.0',
>      default_options : [
>          'werror=true',

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list