[libcamera-devel] [PATCH v4 1/6] checkstyle: Move from pep8 to pycodestyle

Nicolas Dufresne nicolas at ndufresne.ca
Sat Jan 18 21:00:10 CET 2020


From: Nicolas Dufresne <nicolas.dufresne at collabora.com>

The tool has been renamed in 2016 to make it more obvious what it
is doing. There is no other changes needed on our side.

See https://github.com/PyCQA/pycodestyle/issues/466

Signed-off-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 utils/checkstyle.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/utils/checkstyle.py b/utils/checkstyle.py
index 93f0291..7edea25 100755
--- a/utils/checkstyle.py
+++ b/utils/checkstyle.py
@@ -321,10 +321,10 @@ class Pep8Checker(StyleChecker):
         data = ''.join(self.__content).encode('utf-8')
 
         try:
-            ret = subprocess.run(['pep8', '--ignore=E501', '-'],
+            ret = subprocess.run(['pycodestyle', '--ignore=E501', '-'],
                                  input=data, stdout=subprocess.PIPE)
         except FileNotFoundError:
-            issues.append(StyleIssue(0, None, "Please install pep8 to validate python additions"))
+            issues.append(StyleIssue(0, None, "Please install pycodestyle to validate python additions"))
             return issues
 
         results = ret.stdout.decode('utf-8').splitlines()
-- 
2.24.1



More information about the libcamera-devel mailing list