[libcamera-devel] [PATCH v4 6/6] checkstyle: Add a pre-commit hook script

Nicolas Dufresne nicolas at ndufresne.ca
Sat Jan 18 21:00:15 CET 2020


From: Nicolas Dufresne <nicolas.dufresne at collabora.com>

This adds support for pre-commit hook workflow. In pre-commit hook we
check the style on the changes currently staged or the combination
of the index and the last commit if "git commit --amend" is being used.

Signed-off-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 utils/hooks/pre-commit | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100755 utils/hooks/pre-commit

diff --git a/utils/hooks/pre-commit b/utils/hooks/pre-commit
new file mode 100755
index 0000000..47fcbc8
--- /dev/null
+++ b/utils/hooks/pre-commit
@@ -0,0 +1,18 @@
+#!/bin/sh
+
+# Execute the checkstyle script before committing any code. This will fail the
+# commit in case of style issues, ensuring that the developer will notice them.
+# The pre-commit hook can be bypassed with git commit -n to ignore selective
+# changes.
+#
+# To utilise this hook, install this file with:
+#   cp utils/hooks/pre-commit .git/hooks/pre-commit
+
+if ps -ocommand= -p $PPID | grep -- "--amend"
+then
+	args="--amend"
+else
+	args="--staged"
+fi
+
+./utils/checkstyle.py $args
-- 
2.24.1



More information about the libcamera-devel mailing list