[libcamera-devel] [PATCH 1/3] pipeline_handler: Include system header for dev_t

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Mon, Jan 20, 2020 at 12:55:42PM +0000, Kieran Bingham wrote:
> Compiling with gcc 9.2.0-r5 identifies the following compile time
> failure:
> 
> FAILED: src/libcamera/4ab8042@@camera at sha/camera.cpp.o
> c++ -Isrc/libcamera/4ab8042@@camera at sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++14 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera at sha/camera.cpp.o' -MF 'src/libcamera/4ab8042@@camera at sha/camera.cpp.o.d' -o 'src/libcamera/4ab8042@@camera at sha/camera.cpp.o' -c ../src/libcamera/camera.cpp
> In file included from ../src/libcamera/camera.cpp:17:
> ../src/libcamera/include/pipeline_handler.h:91:42: error: 'dev_t' has not been declared
>    91 |        std::unique_ptr<CameraData> data, dev_t devnum = 0);
>       |                                          ^~~~~
> 
> Provide the required header to define the dev_t type.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/include/pipeline_handler.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
> index a6c1e1fbae38..5fa0db51c625 100644
> --- a/src/libcamera/include/pipeline_handler.h
> +++ b/src/libcamera/include/pipeline_handler.h
> @@ -13,6 +13,7 @@
>  #include <set>
>  #include <string>
>  #include <sys/sysmacros.h>
> +#include <sys/types.h>
>  #include <vector>
>  
>  #include <ipa/ipa_interface.h>

-- 
Regards,

Laurent Pinchart