[libcamera-devel] [PATCH] QCam: Swich default stream role to viewfinder.

[Kieran Bingham]

Hi Naush,

Thank you for the patch,

On 31/01/2020 09:52, naush at raspberrypi.com wrote:
> From: Naushir Patuck <naush at raspberrypi.com>
> 
> QCam currently only displays a standard viewfinder.  As such set the
> StreamRole parameter to Viewfinder so that the pipeline handlers can
> setup the appropriate resolutions and formats.

I agree, this makes sense as a sane starting condition.

In the future we can add controls and support to QCam for selecting this
mode at application runtime too, but certainly starting the Viewfinder
up as a Viewfinder sounds perfectly reasonable to me.

> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/qcam/main_window.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp
> index df51fa8..70a3e61 100644
> --- a/src/qcam/main_window.cpp
> +++ b/src/qcam/main_window.cpp
> @@ -125,7 +125,7 @@ int MainWindow::startCapture()
>  {
>  	int ret;
>  
> -	config_ = camera_->generateConfiguration({ StreamRole::VideoRecording });
> +	config_ = camera_->generateConfiguration({ StreamRole::Viewfinder });
>  
>  	StreamConfiguration &cfg = config_->at(0);
>  	if (options_.isSet(OptSize)) {
> 

-- 
Regards
--
Kieran