[libcamera-devel] [RFC 0/2] libcamera: formats: Remove ImageFormats

[Jacopo Mondi]

Hi again,

On Wed, Jul 01, 2020 at 11:16:48PM +0200, Niklas Söderlund wrote:
> Hello,
>
> This is in no way an attempt to conflict with the pending patches to
> ImageFormats on the ML from Jacopo. Following his patches there was a
> discussion if we could instead of making ImageFormats a template make
> use of the new utils::map_keys() helper. I liked the idea and gave it a
> try and the result was not so bad so I thought I send it out as an RFC.
>
> As the new helper is not yet merged this series depends on [1].
>

Happy to see this series getting traction, but to get it merged it
should address the custom maps used by V4L2VideoDevice users,
otherwise the main goal of unifying the handling maps of mbus codes
and v4l2 fourccs is lost.

> 1. [PATCH v2 0/2] libcamera: utils: Add map_keys() function
>
> Niklas Söderlund (2):
>   libcamera: v4l2_subdevice: Replace ImageFormats with a map
>   libcamera: formats: Remove ImageFormats
>
>  include/libcamera/internal/camera_sensor.h  |  6 +-
>  include/libcamera/internal/formats.h        | 14 ----
>  include/libcamera/internal/v4l2_subdevice.h |  4 +-
>  src/libcamera/camera_sensor.cpp             | 12 +--
>  src/libcamera/formats.cpp                   | 88 ---------------------
>  src/libcamera/v4l2_subdevice.cpp            | 16 ++--
>  test/v4l2_subdevice/list_formats.cpp        | 16 ++--
>  7 files changed, 27 insertions(+), 129 deletions(-)
>
> --
> 2.27.0
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel