[libcamera-devel] [PATCH v3 0/2] libcamera: utils: Add map_keys() function

Jacopo Mondi jacopo at jmondi.org
Fri Jul 3 10:43:41 CEST 2020


Hi Niklas

On Fri, Jul 03, 2020 at 01:11:05AM +0200, Niklas Söderlund wrote:
> Hi,
>
> This is mostly Laurent's work that I fished out of the ML so I could
> send out the last IPU3 patches I have locally which makes of Laurent's
> work.
>
> I have modified 1/2 so that the utils::map_keys() helper returns a
> std::vector instead of a std::set after some discussions on v1 and on
> IRC.

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

for both patches, but I think this should aim to remove the custom
V4L2PixelFormat maps from pipeline handlers too, doesn't it ?

Thanks
  j

>
> Laurent Pinchart (1):
>   libcamera: utils: Add map_keys() function
>
> Niklas Söderlund (1):
>   libcamera: ipu3: cio2: Make use of utils::map_keys() helper
>
>  include/libcamera/internal/utils.h   | 10 ++++++++++
>  src/libcamera/pipeline/ipu3/cio2.cpp | 19 +++----------------
>  src/libcamera/utils.cpp              |  7 +++++++
>  test/utils.cpp                       | 22 ++++++++++++++++++++++
>  4 files changed, 42 insertions(+), 16 deletions(-)
>
> --
> 2.27.0
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel


More information about the libcamera-devel mailing list