[libcamera-devel] [PATCH v3 22/22] libcamera: StreamConfiguration: Update stride documentation

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Jul 5 00:03:54 CEST 2020


Hi Paul,

Thank you for the patch.

On Sat, Jul 04, 2020 at 10:31:40PM +0900, Paul Elder wrote:
> Now that all the pipeline handlers fill in the stride information at
> validation time, update the documentation accordingly.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
> New in v3
> ---
>  src/libcamera/stream.cpp | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp
> index 6d6e279..d5da834 100644
> --- a/src/libcamera/stream.cpp
> +++ b/src/libcamera/stream.cpp
> @@ -309,11 +309,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)
>   *
>   * The stride value reports the number of bytes between the beginning of
>   * successive lines in an image buffer for this stream. The value is
> - * valid after successfully configuring the camera with this
> - * configuration with a call to Camera::Configure().
> - *
> - * \todo Update this value when configuration is validated instead of when
> - * the camera is configured.
> + * valid after successfully validating the configuration with a call to
> + * CameraConfiguration::validate().
>   */
>  
>  /**

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list