[libcamera-devel] [PATCH v3 8/8] android: camera_device: Remove single buffer restriction.
Jacopo Mondi
jacopo at jmondi.org
Mon Jul 6 10:04:23 CEST 2020
Hi Kieran
On Fri, Jul 03, 2020 at 01:39:19PM +0100, Kieran Bingham wrote:
> A capture request is no longer limited to a single output buffer.
> Remove the limitation, but (for now) keep the check to ensure that
> at least one buffer is always provided.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
Thanks
j
> ---
> src/android/camera_device.cpp | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index 3d21e59af258..1f85e7e535f5 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -1050,9 +1050,8 @@ FrameBuffer *CameraDevice::createFrameBuffer(const buffer_handle_t camera3buffer
>
> int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Request)
> {
> - if (camera3Request->num_output_buffers != 1) {
> - LOG(HAL, Error) << "Invalid number of output buffers: "
> - << camera3Request->num_output_buffers;
> + if (!camera3Request->num_output_buffers) {
> + LOG(HAL, Error) << "No output buffers provided";
> return -EINVAL;
> }
>
> --
> 2.25.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
More information about the libcamera-devel
mailing list