[libcamera-devel] [PATCH v2 03/20] libcamera: ipu3: Make sure the config is valid

Jacopo Mondi jacopo at jmondi.org
Thu Jul 9 10:41:11 CEST 2020


Inspect the return status of validate() in the IPU3 pipeline handler
generateConfigurtion() implementation. If the generated configuration is
not valid, return a an empty configuration to the application.

Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
 src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index 85d21b4db046..e62a5d5b3517 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -357,7 +357,8 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,
 		config->addConfiguration(cfg);
 	}
 
-	config->validate();
+	if (CameraConfiguration::Invalid == config->validate())
+		return {};
 
 	return config;
 }
-- 
2.27.0



More information about the libcamera-devel mailing list