[libcamera-devel] [PATCH v5 14/23] libcamera: raspberrypi: Set default configuration size at validation

Paul Elder paul.elder at ideasonboard.com
Thu Jul 9 15:28:26 CEST 2020


If a native format is not found, a default NV12 format is set. However,
this does not set a default configuration size, sometimes resulting in a
0x0 size. Fix this by setting a default configuration size.

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

---
New in v5, split from "libcamera: raspberrypi: Fill stride and frameSize
at config validation"
---
 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
index a08ad6a..5f00500 100644
--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
@@ -500,6 +500,9 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()
 		if (fmts.find(V4L2PixelFormat::fromPixelFormat(cfgPixFmt, false)) == fmts.end()) {
 			/* If we cannot find a native format, use a default one. */
 			cfgPixFmt = formats::NV12;
+			cfg.size.width = 1920;
+			cfg.size.height = 1080;
+
 			status = Adjusted;
 		}
 
-- 
2.27.0



More information about the libcamera-devel mailing list