[libcamera-devel] [PATCH v2 07/20] libcamera: ipu3: Remove initialization of Size

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Jul 10 10:36:45 CEST 2020


Hi Jacopo,

Thank you for the patch.

On Thu, Jul 09, 2020 at 10:41:15AM +0200, Jacopo Mondi wrote:
> The Size struct constructor defaults the width and height to 0.
> Remove the empty braced-list initialization as it is not required.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index d27acb405a1d..05e10ebb1a7d 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -245,7 +245,7 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()
>  	 * only. If no resolution is requested for any stream, or if no sensor
>  	 * resolution is large enough, pick the largest one.
>  	 */
> -	Size size = {};
> +	Size size;
>  
>  	for (const StreamConfiguration &cfg : config_) {
>  		if (cfg.size.width > size.width)

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list