[libcamera-devel] [PATCH v2 08/13] media: i2c: ov5647: Parse and register properties
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Jul 15 03:18:28 CEST 2020
Parse device properties and register controls for them using the V4L2
fwnode properties helpers.
Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
drivers/media/i2c/ov5647.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
index 6d84d2785f74..86a821a172b3 100644
--- a/drivers/media/i2c/ov5647.c
+++ b/drivers/media/i2c/ov5647.c
@@ -1501,6 +1501,7 @@ static int ov5647_probe(struct i2c_client *client)
struct device_node *np = client->dev.of_node;
u32 xclk_freq;
int hblank, exposure_max, exposure_def;
+ struct v4l2_fwnode_device_properties props;
sensor = devm_kzalloc(dev, sizeof(*sensor), GFP_KERNEL);
if (!sensor)
@@ -1534,7 +1535,7 @@ static int ov5647_probe(struct i2c_client *client)
mutex_init(&sensor->lock);
/* Initialise controls. */
- v4l2_ctrl_handler_init(&sensor->ctrls, 7);
+ v4l2_ctrl_handler_init(&sensor->ctrls, 9);
v4l2_ctrl_new_std(&sensor->ctrls, &ov5647_ctrl_ops,
V4L2_CID_AUTOGAIN,
0, /* min */
@@ -1598,6 +1599,16 @@ static int ov5647_probe(struct i2c_client *client)
__func__, ret);
goto error;
}
+
+ ret = v4l2_fwnode_device_parse(&client->dev, &props);
+ if (ret)
+ goto error;
+
+ ret = v4l2_ctrl_new_fwnode_properties(&sensor->ctrls, &ov5647_ctrl_ops,
+ &props);
+ if (ret)
+ goto error;
+
sensor->sd.ctrl_handler = &sensor->ctrls;
/* Write out the register set over I2C on stream-on. */
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list