[libcamera-devel] [PATCH v4 19/19] libcamera: ipu3: imgu: Rename configureInput()
Jacopo Mondi
jacopo at jmondi.org
Mon Jul 20 12:47:36 CEST 2020
The ImgUDevice::configureInput() function does not only configure the
input format but applies rectangles to the IF, BDS and GDC components.
Rename it to ImgUDevice::configure().
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
src/libcamera/pipeline/ipu3/imgu.cpp | 5 ++---
src/libcamera/pipeline/ipu3/imgu.h | 2 +-
src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp
index ad51a64a84e4..a3ea3eabe318 100644
--- a/src/libcamera/pipeline/ipu3/imgu.cpp
+++ b/src/libcamera/pipeline/ipu3/imgu.cpp
@@ -424,13 +424,12 @@ ImgUDevice::PipeConfig ImgUDevice::calculatePipeConfig(Pipe *pipe)
}
/**
- * \brief Configure the ImgU unit input
+ * \brief Configure the ImgU pipeline
* \param[in] config The ImgU pipe configuration parameters
* \param[in] inputFormat The format to be applied to ImgU input
* \return 0 on success or a negative error code otherwise
*/
-int ImgUDevice::configureInput(const PipeConfig &pipeConfig,
- V4L2DeviceFormat *inputFormat)
+int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputFormat)
{
/* Configure the ImgU input video device with the requested sizes. */
int ret = input_->setFormat(inputFormat);
diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h
index 91715c78fa83..ff8dab7d645c 100644
--- a/src/libcamera/pipeline/ipu3/imgu.h
+++ b/src/libcamera/pipeline/ipu3/imgu.h
@@ -45,7 +45,7 @@ public:
PipeConfig calculatePipeConfig(Pipe *pipe);
- int configureInput(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputFormat);
+ int configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputFormat);
int configureOutput(const StreamConfiguration &cfg,
V4L2DeviceFormat *outputFormat)
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index d7c0076a57e3..06afc7d79dac 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -475,7 +475,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)
if (imguConfig.isNull())
return 0;
- ret = imgu->configureInput(imguConfig, &cio2Format);
+ ret = imgu->configure(imguConfig, &cio2Format);
if (ret)
return ret;
--
2.27.0
More information about the libcamera-devel
mailing list