[libcamera-devel] [PATCH v4 4/9] libcamera: pipeline: raspberrypi: Increase the number of RAW buffers

[Kieran Bingham]

Hi Naush,

On 20/07/2020 10:13, Naushir Patuck wrote:
> Increase the number of expected RAW buffers in the stream configuration
> to 2. This will avoid dropping Unicam frames when exporting RAW streams.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

I guess this is lower than other streams to keep memory consumption to a
minimum too...

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> index 35f14dda..486345fa 100644
> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> @@ -379,7 +379,7 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,
>  			sensorFormat = findBestMode(fmts, size);
>  			pixelFormat = sensorFormat.fourcc.toPixelFormat();
>  			ASSERT(pixelFormat.isValid());
> -			bufferCount = 1;
> +			bufferCount = 2;
>  			rawCount++;
>  			break;
>  
> 

-- 
Regards
--
Kieran