[libcamera-devel] [PATCH v4 0/9] Zero-copy RAW stream work

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Jul 22 16:53:42 CEST 2020


Hi David,

On Tue, Jul 21, 2020 at 11:13:03AM +0100, David Plowman wrote:
> Hi Naush, everyone
> 
> Thanks for all these patches! I've downloaded and tried them, with our
> nascent raspistill replacement as well as in qcam and it's all been
> working well for me.
> 
> Can I add
> 
> Tested-by: David Plowman <david.plowman at raspberrypi.com>
> 
> to all the patches?

Sure :-) Naush mentioned he will post a new version, I thus expect him
to add your tag to the patches.

> On Mon, 20 Jul 2020 at 10:13, Naushir Patuck <naush at raspberrypi.com> wrote:
> >
> > Hi,
> >
> > Here is v4 of the patch set.  I have removed the patch related to external buffer
> > handling.  This needs a bit more though on how to implement, but should be fine,
> > as no application uses this method of buffer handling yet.  This will be added
> > separately.
> >
> > Regards,
> > Naush
> >
> >
> > Naushir Patuck (9):
> >   libcamera: pipeline: raspberrypi: Move RPiStream into a separate file
> >   libcamera: pipeline: ipa: raspberrypi: Rework drop frame signalling
> >   libcamera: pipeline: raspberrypi: Add some debug logging
> >   libcamera: pipeline: raspberrypi: Increase the number of RAW buffers
> >   libcamera: pipeline: raspberrypi: Remove const qualifier from
> >     RPiStream
> >   libcamera: pipeline: raspberrypi: Rework stream buffer logic for
> >     zero-copy
> >   libcamera: pipeline: raspberrypi: Fix bug in passing configuration to
> >     IPA
> >   libcamera: pipeline: raspberrypi: Add more robust stream buffer logic
> >   libcamera: pipeline: ipa: raspberrypi: Remove use of FrameBuffer
> >     cookie
> >
> >  include/libcamera/ipa/raspberrypi.h           |   2 +-
> >  src/ipa/raspberrypi/raspberrypi.cpp           |  20 +-
> >  .../pipeline/raspberrypi/meson.build          |   1 +
> >  .../pipeline/raspberrypi/raspberrypi.cpp      | 524 +++++++-----------
> >  .../pipeline/raspberrypi/rpi_stream.cpp       | 216 ++++++++
> >  .../pipeline/raspberrypi/rpi_stream.h         | 118 ++++
> >  6 files changed, 546 insertions(+), 335 deletions(-)
> >  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
> >  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.h

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list