[libcamera-devel] [PATCH] libcamera: formats: Remove unnecessary explicit constructor calls

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Jul 24 01:38:52 CEST 2020


When initializing the PixelFormatInfo::format field with a PixelFormat,
there's no need to cal the PixelFormat (copy) constructor explicitly.
Remove the unnecessary calls.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/libcamera/formats.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp
index 60b42ce23c21..11774b0cfb12 100644
--- a/src/libcamera/formats.cpp
+++ b/src/libcamera/formats.cpp
@@ -321,7 +321,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{
 	} },
 	{ formats::YUV420, {
 		.name = "YUV420",
-		.format = PixelFormat(formats::YUV420),
+		.format = formats::YUV420,
 		.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YUV420),
 		.bitsPerPixel = 12,
 		.colourEncoding = PixelFormatInfo::ColourEncodingYUV,
@@ -331,7 +331,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{
 	} },
 	{ formats::YVU420, {
 		.name = "YVU420",
-		.format = PixelFormat(formats::YVU420),
+		.format = formats::YVU420,
 		.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YVU420),
 		.bitsPerPixel = 12,
 		.colourEncoding = PixelFormatInfo::ColourEncodingYUV,
@@ -341,7 +341,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{
 	} },
 	{ formats::YUV422, {
 		.name = "YUV422",
-		.format = PixelFormat(formats::YUV422),
+		.format = formats::YUV422,
 		.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YUV422P),
 		.bitsPerPixel = 16,
 		.colourEncoding = PixelFormatInfo::ColourEncodingYUV,
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list