[libcamera-devel] [PATCH 2/4] android: camera_device: Use HAL_PIXEL_FORMAT_* defines for formats

[Jacopo Mondi]

Hi Niklas,

On Fri, Jul 24, 2020 at 10:44:23AM +0200, Niklas Söderlund wrote:
> Hi Jacopo,
>
> Thanks for your feedback.
>
> On 2020-07-24 10:43:23 +0200, Jacopo Mondi wrote:
> > Hi Niklas,
> >
> > On Thu, Jul 23, 2020 at 07:39:40PM +0200, Niklas Söderlund wrote:
> > > The documentation says the HAL_PIXEL_FORMAT_* defines shall be used for
> > > formats instead of ANDROID_SCALER_AVAILABLE_FORMATS_* for the
> > > ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS and
> > > ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS tags.
> > >
> > > This have worked in the past as the numerical value of the two sets are
> > > the same for the formats supported.
> >
> > I wonder if in the future we would need scaler formats for other
> > properties, but as the numerical values are the same, we could use the
> > HAL_PIXEL_FORMAT_* definitions.
> >
> > Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
>
> Was this comment and tag indented for 3/4 ?
>

Yes :)

Sorry for confusion