[libcamera-devel] [PATCH v2 0/4] android: camera_device: Improve on format related tags

[Laurent Pinchart]

Hi Niklas,

Thank you for the patches.

On Fri, Jul 24, 2020 at 11:07:40AM +0200, Niklas Söderlund wrote:
> Hi,
> 
> While working on extending the HAL to support RAW format I stumbled upon
> some small issues with how we report formats to users. These where found
> running the Open Camera application [1] under a debugger and observing
> how it consumed tags and by reading the Android documentation.
> 
> I have tested these changes together with Kieran's JPEG work and the
> stock camera applications behaves the same as it does without this
> series so I'm not able to provoke any regressions.
> 
> This series is a preparation for a small series enabling RAW streams in
> the HAL. Using this series, the JPEG work and a yet to be sent RAW
> series I mange to light up the RAW capture options in Open Camera while
> retaining a functioning stock camera application.
> 
> 1. https://opencamera.org.uk/
> 
> Niklas Söderlund (4):
>   android: camera_device: Remove ANDROID_SCALER_AVAILABLE_FORMATS
>   android: camera_device: Use HAL_PIXEL_FORMAT_* defines for formats
>   android: camera_device: Remove scaler format information from
>     Camera3Format
>   android: camera_device: Add ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS

For the whole series,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  src/android/camera_device.cpp | 35 ++++++++++++-----------------------
>  src/android/camera_device.h   |  2 +-
>  2 files changed, 13 insertions(+), 24 deletions(-)
> 

-- 
Regards,

Laurent Pinchart