[libcamera-devel] [PATCH v2 2/6] android: camera_metadata: Add const version of get()

[Laurent Pinchart]

Hi Jacopo,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

On Sat, Jul 25, 2020 at 04:40:54PM +0200, Jacopo Mondi wrote:
> Add a const version of the CameraMetadata::get() method to retrieve
> a const reference to the camera metadata wrapped by the class instance.

s/reference/pointer/ ?

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.comR

Here too, s/comR/com>/

> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/android/camera_metadata.cpp | 5 +++++
>  src/android/camera_metadata.h   | 1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp
> index 47b2e4ef117a..ea33e9c2de25 100644
> --- a/src/android/camera_metadata.cpp
> +++ b/src/android/camera_metadata.cpp
> @@ -50,3 +50,8 @@ camera_metadata_t *CameraMetadata::get()
>  {
>  	return valid_ ? metadata_ : nullptr;
>  }
> +
> +const camera_metadata_t *CameraMetadata::get() const
> +{
> +	return valid_ ? metadata_ : nullptr;
> +}
> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h
> index 348a018165ef..f16dd27bbf44 100644
> --- a/src/android/camera_metadata.h
> +++ b/src/android/camera_metadata.h
> @@ -21,6 +21,7 @@ public:
>  	bool addEntry(uint32_t tag, const void *data, size_t data_count);
>  
>  	camera_metadata_t *get();
> +	const camera_metadata_t *get() const;
>  
>  private:
>  	camera_metadata_t *metadata_;

-- 
Regards,

Laurent Pinchart