[libcamera-devel] [PATCH 1/3] android: camera_device: Skip instead of fail if camera don't support format

Niklas Söderlund niklas.soderlund at ragnatech.se
Tue Jul 28 20:55:46 CEST 2020


If the libcamera Camera don't support the Android format do not fail the
initialization. Instead skip adding the Android format to the list of
supported formats reported.

This allows extending the camera3FormatsMap with Android formats not
supported by all libcamera Cameras and probe and report only the ones
that overlap.

Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
---
 src/android/camera_device.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index b49d6681e5a52d32..265627a98422bd67 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -282,10 +282,10 @@ int CameraDevice::initializeStreamConfigurations()
 			}
 		}
 		if (!mappedFormat.isValid()) {
-			LOG(HAL, Error) << "Failed to map Android format "
+			LOG(HAL, Debug) << "Failed to map Android format "
 					<< camera3Format.name << " ("
 					<< utils::hex(androidFormat) << ")";
-			return -EINVAL;
+			continue;
 		}
 
 		/*
-- 
2.27.0



More information about the libcamera-devel mailing list