[libcamera-devel] [PATCH] android: camera_hal_manager: Fail on no cameras

[Laurent Pinchart]

Hi Jacopo,

On Tue, Jul 28, 2020 at 04:12:29PM +0200, Jacopo Mondi wrote:
> On Mon, Jul 27, 2020 at 01:00:12PM +0200, Tomasz Figa wrote:
> > On Mon, Jul 27, 2020 at 12:52 PM Laurent Pinchart wrote:
> > > > >>
> > > > >> Yes, it's a recent change for a new platform where we ended up with
> > > > >> dynamic detection of components. Actually it hasn't landed yet. The CL
> > > > >> for reference is
> > > > >> https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2239080.
> 
> FWIW I tested
> https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2239080
> applied to libcamera and not to ipu6, with
> https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2239846/2/camera/hal_adapter/init/cros-camera.conf
> 
> and I have two cameras registered at ARC++ start up.
> 
> I think we can drop this patch and just keep it as a local fix to run
> CTS or Android camera applications, and drop it when the above change
> lands in upstream chromium

Nice !! Thank you for testing.

> > > > > Do you happen to know why I see this issue being triggered only for
> > > > > CTS which goes through the android services ? It goes through the
> > > > > cros_camera_service if I got the architecture right, but even without
> > > > > this patch, the camera service is always able to identify both
> > > > > cameras...
> > > > >
> > > > > It is still not clear to me if the android camera service (is this ARC++?)
> > > > > interacts with the cros_camera_service through the same mojo interface
> > > > > as stock ChromeOS camera application (and cros_camera_test?) use or
> > > > > there's a different interface for it..
> > > >
> > > > Yes, Android interacts with the cros_camera service using the same
> > > > interface. I think it's just that Android camera frameworks cache the
> > > > camera metadata when they query it the first time and would ignore any
> > > > later changes. On the contrary, Chrome probably just queries the
> > > > metadata every time some camera use case is executed.
> > >
> > > IS there a service that could be restarted to reset the Android camera
> > > framework state instead of rebooting the device ?
> >
> > I'm not sure unfortunately. I think logging out and in again in Chrome
> > OS should restart the Android container, but not sure if that improves
> > anything. Also given that inside the container is just plain Android,
> > maybe there is some generic Android way to reload the camera HAL?

-- 
Regards,

Laurent Pinchart