[libcamera-devel] [PATCH v5 00/10] Zero-copy RAW stream work

Naushir Patuck naush at raspberrypi.com
Thu Jul 30 10:39:38 CEST 2020


Hi all,

Is there any further changes anyone would like me to make for this
series?  I know Laurent had comments on what I was trying to achieve
in patches 09/10 and 10/10 - I have made some minor changes with
variable names and comments to hopefully explain the code better.  If
there are other clarifications to be made, please let me know and I
will be happy to do so.

Regards,
Naush

On Fri, 24 Jul 2020 at 08:22, Naushir Patuck <naush at raspberrypi.com> wrote:
>
> Hi,
>
> This is patchset v5 of the zero copy RAW stream work for the Raspberry Pi platform.
> All minor changes in the review feedback have been addressed.  The only other difference
> is in patch 9/10 where I have renamed requeueBuffers_ to requestBuffers_ and made minor
> changes to the comments to hopefully make the usage slightly more understandable.  I
> have left the review tags in place, as there is no functional change, hope that is ok.
>
> Regards,
> Naush
>
> Naushir Patuck (10):
>   libcamera: pipeline: raspberrypi: Move RPiStream into a separate file
>   libcamera: pipeline: ipa: raspberrypi: Rework drop frame signalling
>   libcamera: request: Add log point on a completed request
>   libcamera: pipeline: raspberrypi: Add some debug logging
>   libcamera: pipeline: raspberrypi: Increase the number of RAW buffers
>   libcamera: pipeline: raspberrypi: Remove const qualifier from
>     RPiStream
>   libcamera: pipeline: raspberrypi: Rework stream buffer logic for
>     zero-copy
>   libcamera: pipeline: raspberrypi: Fix bug in passing configuration to
>     IPA
>   libcamera: pipeline: raspberrypi: Add more robust stream buffer logic
>   libcamera: pipeline: ipa: raspberrypi: Remove use of FrameBuffer
>     cookie
>
>  include/libcamera/ipa/raspberrypi.h           |   2 +-
>  src/ipa/raspberrypi/raspberrypi.cpp           |  20 +-
>  .../pipeline/raspberrypi/meson.build          |   1 +
>  .../pipeline/raspberrypi/raspberrypi.cpp      | 522 +++++++-----------
>  .../pipeline/raspberrypi/rpi_stream.cpp       | 216 ++++++++
>  .../pipeline/raspberrypi/rpi_stream.h         | 131 +++++
>  src/libcamera/request.cpp                     |   3 +
>  7 files changed, 563 insertions(+), 332 deletions(-)
>  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
>  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.h
>
> --
> 2.25.1
>


More information about the libcamera-devel mailing list