[libcamera-devel] [PATCH v2 0/4] Raspberry Pi ALSC improvements

David Plowman david.plowman at raspberrypi.com
Fri Jul 31 16:07:57 CEST 2020


Hi

Same patches as previously, and indeed the first and last are
unchanged. I've added a second patch which improves the locking as per
our discussion. Actually - and I think we'd both failed to notice! -
restartAsync was always called with the lock held, so it's simply a
case of not holding the lock that long. (Looking back at the original
verion of this code, Prepare and Process ran asynchronously too so
more locking was necessary.)

Laurent, I've applied your "Reviewed-by" to the first and last
patches, I think that was the intention. Obviously we await Naush next
week.

Best regards
David

David Plowman (4):
  libcamera: ipa: raspberrypi: ALSC: Camera mode does not need to be
    atomic
  libcamera: ipa: raspberrypi: ALSC: Improve locking in a few places
  libcamera: ipa: raspberrypi: ALSC: Resample luminance table
  libcamera: ipa: raspberrypi: ALSC: Improve behaviour when camera mode
    changes

 src/ipa/raspberrypi/controller/rpi/alsc.cpp | 99 ++++++++++++++-------
 src/ipa/raspberrypi/controller/rpi/alsc.hpp |  5 +-
 2 files changed, 70 insertions(+), 34 deletions(-)

-- 
2.20.1



More information about the libcamera-devel mailing list