[libcamera-devel] [PATCH v2] pipeline: raspberrypi: Fix for staggered write on reset

[Kieran Bingham]

Hi Naush,

On 29/05/2020 08:16, Naushir Patuck wrote:
> The reset function in staggered write was using the wrong index when
> looking for the last updated camera parameters. This would cause
> possibly stale exposure values to be written to the camera on a
> mode switch for captures.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>

This looks fine to me,

I'll apply it for you if no one has any issues.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp
> index 391e13f5..5ed63a8e 100644
> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp
> @@ -46,7 +46,7 @@ void StaggeredCtrl::reset()
>  {
>  	std::lock_guard<std::mutex> lock(lock_);
>  
> -	int lastSetCount = std::max<int>(0, setCount_ - 1);
> +	int lastSetCount = setCount_;
>  	std::unordered_map<uint32_t, int32_t> lastVal;
>  
>  	/* Reset the counters. */
> 

-- 
Regards
--
Kieran