[libcamera-devel] [PATCH 02/10] libcamera: ipu3: Remove id from camera names

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Tue, Jun 02, 2020 at 03:39:01AM +0200, Niklas Söderlund wrote:
> The id in the camera name is confusing and is of little use for users.
> Camera names are not (yet) required to be unique and appending which
> numerical CIO2 unit the sensor is attached to is just as good as
> depending on the i2c bus information already present in the entity name.
> 
> Before this change,
> 
>     $ cam -l
>     Available cameras:
>     1: ov13858 2-0010 0
>     2: ov5670 4-0036 1
> 
> After this change,
> 
>     $ cam -l
>     Available cameras:
>     1: ov13858 2-0010
>     2: ov5670 4-0036
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Can't wait to fix the camera naming issue though :-)

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index b805fea71c2d812d..6df1e29281941ebf 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -949,8 +949,7 @@ int PipelineHandlerIPU3::registerCameras()
>  					&IPU3CameraData::imguOutputBufferReady);
>  
>  		/* Create and register the Camera instance. */
> -		std::string cameraName = cio2->sensor_->entity()->name() + " "
> -				       + std::to_string(id);
> +		std::string cameraName = cio2->sensor_->entity()->name();
>  		std::shared_ptr<Camera> camera = Camera::create(this,
>  								cameraName,
>  								streams);

-- 
Regards,

Laurent Pinchart