[libcamera-devel] [PATCH] gitignore: Ignore all build directories

[Jacopo Mondi]

Hi Kieran,

On Thu, Jun 04, 2020 at 10:22:11AM +0100, Kieran Bingham wrote:
>
>
> On 04/06/2020 10:15, Laurent Pinchart wrote:
> > On Thu, Jun 04, 2020 at 10:09:54AM +0100, Kieran Bingham wrote:
> >> On 04/06/2020 10:07, Laurent Pinchart wrote:
> >>> Hi Kieran,
> >>>
> >>> Thank you for the patch.
> >>>
> >>> On Thu, Jun 04, 2020 at 09:49:08AM +0100, Kieran Bingham wrote:
> >>>> It can be common to have multiple build directories with different
> >>>> configurations. Ignore them all.
> >>>>
> >>>> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> >>>> ---
> >>>>  .gitignore | 2 +-
> >>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/.gitignore b/.gitignore
> >>>> index f989dee3bcb0..aecf971d30aa 100644
> >>>> --- a/.gitignore
> >>>> +++ b/.gitignore
> >>>> @@ -1,5 +1,5 @@
> >>>>  __pycache__/
> >>>> -build/
> >>>> +*build*/
> >>>
> >>> That's a bit of a too generic pattern, we could later have a directory
> >>> with build in its name.
> >>>
> >>> I personally have a single build/ directory directly at the root of the
> >>> source tree, and create subdirectories there for different builds. All
> >>> it requires is 'meson setup ../..' instead of 'meson setup ..' (and it
> >>> works fine with the the run-from-build-dir support we have). Could that
> >>> be a solution you would consider instead of this patch ?
> >>
> >> how about ./*build*/ to only match on the root then.
> >
> > I'm still cautious about patterns that could have unexpected matches :-)
> > And what if someone wants to name their build directories differently ?
>
> Does anyone else have multiple builds at the root?
>
Currently 4
I the past I had more...

build-aarch64
build-armv7
build-clang
build-gcc

> > I think .gitignore should include minimal policy, if we can restrict
> > ignoring the builds to a single directory, I'd prefer that (I'm even
> > tempted to say we shouldn't include build/ in .gitignore, but I agree
> > it's useful).
>
> Never mind, I'll carry it locally.
>
>
>
> >
> >>>>  patches/
> >>>>  *.patch
> >>>>  *.pyc
> >
>
> --
> Regards
> --
> Kieran
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel