[libcamera-devel] [PATCH 6/6] libcamera: camera: Order parameter documentation correctly

Marvin Schmidt marvin.schmidt1987 at gmail.com
Fri Jun 5 10:16:27 CEST 2020


Am Do., 4. Juni 2020 um 15:54 Uhr schrieb Kieran Bingham
<kieran.bingham at ideasonboard.com>:
>
> Hi Marvin,
>
> This checks out too!
>
> Thank you for the fixups.
>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>

Hey Kieran,

thank you for you instant review! I'm glad to help :-)

I'll add your R-b tags and send v2

> On 04/06/2020 14:43, Marvin Schmidt wrote:
> > ---
> >  src/libcamera/camera.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp
> > index dfc3d19..6033f47 100644
> > --- a/src/libcamera/camera.cpp
> > +++ b/src/libcamera/camera.cpp
> > @@ -449,8 +449,8 @@ void Camera::Private::setState(State state)
> >
> >  /**
> >   * \brief Create a camera instance
> > - * \param[in] name The name of the camera device
> >   * \param[in] pipe The pipeline handler responsible for the camera device
> > + * \param[in] name The name of the camera device
> >   * \param[in] streams Array of streams the camera provides
> >   *
> >   * The caller is responsible for guaranteeing unicity of the camera name.
> >
>
> --
> Regards
> --
> Kieran


More information about the libcamera-devel mailing list