[libcamera-devel] [PATCH v5] meson: detect kernel version

[Kieran Bingham]

Hi Stéphane

On 11/06/2020 11:26, Stéphane Cerveau wrote:
> Add kernel version detection to warn user
> that only >= 5.0.0 V4L API are supported in
> libcamera.
> 
> Signed-off-by: Stéphane Cerveau <scerveau at collabora.com>

Please carry tags you receive forwards on patches, unless they need to
be dropped perhaps due to drastic changes or re-architecture of the patch.

In this instance, you can carry my RB tag from v4 to this patch:

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  meson.build | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index e898782..69d2d63 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -105,6 +105,15 @@ if get_option('test')
>      subdir('test')
>  endif
>  
> +if not meson.is_cross_build()
> +  kernel_version_req = '>= 5.0.0'
> +  kernel_version = run_command('uname', '-r').stdout()
> +  if not kernel_version.version_compare(kernel_version_req)
> +    warning('Consider upgrading your kernel, as only @0@ is supported by libcamera at runtime'
> +            .format(kernel_version_req))
> +  endif
> +endif
> +
>  # Create a symlink from the build root to the source root. This is used when
>  # running libcamera from the build directory to locate resources in the source
>  # directory (such as IPA configuration files).
> 

-- 
Regards
--
Kieran