[libcamera-devel] [PATCH] Fix incorrect method in cameradata docs

[Umang Jain]

Hi Chris,

On 6/15/20 8:19 PM, chris at gregariousmammal.com wrote:
> From: Chris Chinchilla <chris at gregariousmammal.com>
>
> ---
>   src/libcamera/pipeline_handler.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
> index a0f6b0f..fca11cb 100644
> --- a/src/libcamera/pipeline_handler.cpp
> +++ b/src/libcamera/pipeline_handler.cpp
> @@ -46,7 +46,7 @@ LOG_DEFINE_CATEGORY(Pipeline)
>    *
>    * Pipeline handlers are expected to extend this base class with platform
>    * specific implementation, associate instances of the derived classes
> - * using the setCameraData() method, and access them at a later time
> + * using the registerCamera() method, and access them at a later time
>    * with cameraData().
>    */
>   

The change looks good. :-)

Couple of comments on the commit message.

* Missing sign-off tag

    - Patches need to signed off. You can use --signoff flag while 
committing (git commit --signoff ...)

* Missing "Fixes:" tag
    - This commit actually fixes commit: b581b9576abd ("libcamera: 
pipeline_handler: Make pipeline-specific data mandatory"), so add this 
tag to the commit message:

 > Fixes: b581b9576abd ("libcamera: pipeline_handler: Make 
pipeline-specific data mandatory")


Once you have these two things in your commit message:

Reviewed-by: Umang Jain <email at uajain.com>