[libcamera-devel] [PATCH v2 07/17] v4l2: v4l2_camera_proxy: Implement VIDIOC_ENUM_FRAMESIZES

[Paul Elder]

Implement VIDIOC_ENUM_FRAMESIZES in the V4L2 compatibility layer.

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

---
Changes in v2:
- use V4L2CameraFile instead of fd
- added todo for not many pipeline handlers reporting StreamFormats
---
 src/v4l2/v4l2_camera_proxy.cpp | 26 ++++++++++++++++++++++++++
 src/v4l2/v4l2_camera_proxy.h   |  1 +
 2 files changed, 27 insertions(+)

diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
index 3ac9068..c3032f5 100644
--- a/src/v4l2/v4l2_camera_proxy.cpp
+++ b/src/v4l2/v4l2_camera_proxy.cpp
@@ -241,6 +241,28 @@ int V4L2CameraProxy::vidioc_querycap(struct v4l2_capability *arg)
 	return 0;
 }
 
+int V4L2CameraProxy::vidioc_enum_framesizes(V4L2CameraFile *cf, struct v4l2_frmsizeenum *arg)
+{
+	LOG(V4L2Compat, Debug) << "Servicing vidioc_enum_framesizes fd = " << cf->efd();
+
+	PixelFormat argFormat = v4l2ToDrm(arg->pixel_format);
+	/*
+	 * \todo This might need to be expanded as few pipeline handlers
+	 * report StreamFormats.
+	 */
+	const std::vector<Size> &frameSizes = streamConfig_.formats().sizes(argFormat);
+
+	if (arg->index >= frameSizes.size())
+		return -EINVAL;
+
+	arg->type = V4L2_FRMSIZE_TYPE_DISCRETE;
+	arg->discrete.width = frameSizes[arg->index].width;
+	arg->discrete.height = frameSizes[arg->index].height;
+	memset(arg->reserved, 0, sizeof(arg->reserved));
+
+	return 0;
+}
+
 int V4L2CameraProxy::vidioc_enum_fmt(V4L2CameraFile *cf, struct v4l2_fmtdesc *arg)
 {
 	LOG(V4L2Compat, Debug) << "Servicing vidioc_enum_fmt fd = " << cf->efd();
@@ -624,6 +646,7 @@ int V4L2CameraProxy::vidioc_streamoff(V4L2CameraFile *cf, int *arg)
 
 std::set<unsigned long> V4L2CameraProxy::supportedIoctls_ = {
 	VIDIOC_QUERYCAP,
+	VIDIOC_ENUM_FRAMESIZES,
 	VIDIOC_ENUM_FMT,
 	VIDIOC_G_FMT,
 	VIDIOC_S_FMT,
@@ -658,6 +681,9 @@ int V4L2CameraProxy::ioctl(V4L2CameraFile *cf, unsigned long request, void *arg)
 	case VIDIOC_QUERYCAP:
 		ret = vidioc_querycap(static_cast<struct v4l2_capability *>(arg));
 		break;
+	case VIDIOC_ENUM_FRAMESIZES:
+		ret = vidioc_enum_framesizes(cf, static_cast<struct v4l2_frmsizeenum *>(arg));
+		break;
 	case VIDIOC_ENUM_FMT:
 		ret = vidioc_enum_fmt(cf, static_cast<struct v4l2_fmtdesc *>(arg));
 		break;
diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h
index 46573e7..363d366 100644
--- a/src/v4l2/v4l2_camera_proxy.h
+++ b/src/v4l2/v4l2_camera_proxy.h
@@ -47,6 +47,7 @@ private:
 	int freeBuffers();
 
 	int vidioc_querycap(struct v4l2_capability *arg);
+	int vidioc_enum_framesizes(V4L2CameraFile *cf, struct v4l2_frmsizeenum *arg);
 	int vidioc_enum_fmt(V4L2CameraFile *cf, struct v4l2_fmtdesc *arg);
 	int vidioc_g_fmt(V4L2CameraFile *cf, struct v4l2_format *arg);
 	int vidioc_s_fmt(V4L2CameraFile *cf, struct v4l2_format *arg);
-- 
2.27.0